Bug #921

Inline Files - Insert Button

Added by Richard Brandon over 2 years ago. Updated over 2 years ago.

Status:CompletedStart date:08/04/2011
Priority:NormalDue date:
Assignee:Matt Petrovic% Done:

100%

Category:-
Target version:2.0-beta12

Description

When I upload more than one file the insert button appears many times.

History

#1 Updated by Richard Brandon over 2 years ago

  • Subject changed from Inline Files to Inline Files - Insert Button

#2 Updated by Jon Sagotsky over 2 years ago

I have a slightly different but probably related problem too. If I browse for a file and let it automatically upload, when I then click "add another item" the original item is cloned under the Inline Files header in addition to the new upload field. Subsequent adds do not clone the original again.

That is in addition to the insert button being repeatedly appended.

#3 Updated by Matt Petrovic over 2 years ago

Jon, I think that bug is more a result of what Firefox does with the source it's given. For some reason, Firefox pulls the field elements out of the table cell. So when you click Add More, and the ahah result is returned, the old form element isn't replaced like it should be.

While I thought it was a Firefox issue, turning off Javascript made it appear correctly. I just need to find which script is pulling the div out of place and fix it.

#4 Updated by Matt Petrovic over 2 years ago

  • Status changed from New to In Dev
  • % Done changed from 0 to 50

Initial ticket is done.
https://github.com/openscholar/openscholar/commit/2b59f7c34ac8feac2c4a7724098f44504efefbce

I've found what's causing the bug Jon reported. Just need to undo it.

#5 Updated by Matt Petrovic over 2 years ago

  • Status changed from In Dev to In QA
  • % Done changed from 50 to 90

#6 Updated by Jon Sagotsky over 2 years ago

  • Status changed from In QA to Completed
  • % Done changed from 90 to 100

Also available in: Atom PDF